Some fixes in tilemul tester#320
Open
tmagomedov wants to merge 2 commits intoclMathLibraries:developfrom
Open
Conversation
TILEMUL_SKEWS, TILEMUL_OPTIMIZE_COORD_CALC
it is working at least on global matrixes now
Author
|
Any comments on this? I see build checks have failed but seems this is configuration problem -- OpenCL not found by CMake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
t_tilemul debugging tool fails with division by zero in current development branch. With this changes it works at least with global memory matrices (default option). Some deprecated unused options of tilemul generator were also removed.
test-short passed on my machine (Tonga, AMDGPU-PRO 17.10)